Features: - Support login via phone number or email (LoginRequest) - Add members:import-roster command for Excel roster import - Merge survey emails with roster data Code Quality (Phase 1-4): - Add database locking for balance calculation - Add self-approval checks for finance workflow - Create service layer (FinanceDocumentApprovalService, PaymentVerificationService) - Add HasAccountingEntries and HasApprovalWorkflow traits - Create FormRequest classes for validation - Add status-badge component - Define authorization gates in AuthServiceProvider - Add accounting config file Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
111 lines
3.9 KiB
PHP
111 lines
3.9 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature\Validation;
|
|
|
|
use App\Http\Middleware\VerifyCsrfToken;
|
|
use App\Models\FinanceDocument;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Storage;
|
|
use Tests\TestCase;
|
|
use Tests\Traits\CreatesFinanceData;
|
|
use Tests\Traits\SeedsRolesAndPermissions;
|
|
|
|
/**
|
|
* Finance Document Validation Tests
|
|
*
|
|
* Tests finance document model behavior and amount tiers.
|
|
* Uses new workflow: Secretary → Chair → Board
|
|
*/
|
|
class FinanceDocumentValidationTest extends TestCase
|
|
{
|
|
use CreatesFinanceData, RefreshDatabase, SeedsRolesAndPermissions;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
Storage::fake('local');
|
|
$this->seedRolesAndPermissions();
|
|
}
|
|
|
|
public function test_amount_tier_small(): void
|
|
{
|
|
$document = $this->createFinanceDocument(['amount' => 3000]);
|
|
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_SMALL, $document->determineAmountTier());
|
|
}
|
|
|
|
public function test_amount_tier_medium(): void
|
|
{
|
|
$document = $this->createFinanceDocument(['amount' => 25000]);
|
|
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_MEDIUM, $document->determineAmountTier());
|
|
}
|
|
|
|
public function test_amount_tier_large(): void
|
|
{
|
|
$document = $this->createFinanceDocument(['amount' => 75000]);
|
|
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_LARGE, $document->determineAmountTier());
|
|
}
|
|
|
|
public function test_document_amount_boundary_small_medium(): void
|
|
{
|
|
// 4999 should be small
|
|
$smallDoc = $this->createFinanceDocument(['amount' => 4999]);
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_SMALL, $smallDoc->determineAmountTier());
|
|
|
|
// 5000 should be medium
|
|
$mediumDoc = $this->createFinanceDocument(['amount' => 5000]);
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_MEDIUM, $mediumDoc->determineAmountTier());
|
|
}
|
|
|
|
public function test_document_amount_boundary_medium_large(): void
|
|
{
|
|
// 50000 should be medium
|
|
$mediumDoc = $this->createFinanceDocument(['amount' => 50000]);
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_MEDIUM, $mediumDoc->determineAmountTier());
|
|
|
|
// 50001 should be large
|
|
$largeDoc = $this->createFinanceDocument(['amount' => 50001]);
|
|
$this->assertEquals(FinanceDocument::AMOUNT_TIER_LARGE, $largeDoc->determineAmountTier());
|
|
}
|
|
|
|
public function test_document_status_constants(): void
|
|
{
|
|
$this->assertEquals('pending', FinanceDocument::STATUS_PENDING);
|
|
$this->assertEquals('approved_secretary', FinanceDocument::STATUS_APPROVED_SECRETARY);
|
|
$this->assertEquals('approved_chair', FinanceDocument::STATUS_APPROVED_CHAIR);
|
|
$this->assertEquals('approved_board', FinanceDocument::STATUS_APPROVED_BOARD);
|
|
$this->assertEquals('rejected', FinanceDocument::STATUS_REJECTED);
|
|
}
|
|
|
|
public function test_secretary_can_approve_pending_document(): void
|
|
{
|
|
$secretary = $this->createSecretary();
|
|
$document = $this->createFinanceDocument(['status' => FinanceDocument::STATUS_PENDING]);
|
|
|
|
$response = $this->withoutMiddleware(VerifyCsrfToken::class)
|
|
->actingAs($secretary)
|
|
->post(route('admin.finance.approve', $document));
|
|
|
|
$document->refresh();
|
|
$this->assertEquals(FinanceDocument::STATUS_APPROVED_SECRETARY, $document->status);
|
|
}
|
|
|
|
public function test_secretary_can_reject_pending_document(): void
|
|
{
|
|
$secretary = $this->createSecretary();
|
|
$document = $this->createFinanceDocument(['status' => FinanceDocument::STATUS_PENDING]);
|
|
|
|
$response = $this->withoutMiddleware(VerifyCsrfToken::class)
|
|
->actingAs($secretary)
|
|
->post(
|
|
route('admin.finance.reject', $document),
|
|
['rejection_reason' => 'Test rejection']
|
|
);
|
|
|
|
$document->refresh();
|
|
$this->assertEquals(FinanceDocument::STATUS_REJECTED, $document->status);
|
|
}
|
|
}
|