Add phone login support and member import functionality
Features: - Support login via phone number or email (LoginRequest) - Add members:import-roster command for Excel roster import - Merge survey emails with roster data Code Quality (Phase 1-4): - Add database locking for balance calculation - Add self-approval checks for finance workflow - Create service layer (FinanceDocumentApprovalService, PaymentVerificationService) - Add HasAccountingEntries and HasApprovalWorkflow traits - Create FormRequest classes for validation - Add status-badge component - Define authorization gates in AuthServiceProvider - Add accounting config file Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -2,6 +2,8 @@
|
||||
|
||||
namespace App\Http\Controllers;
|
||||
|
||||
use App\Http\Requests\StoreIssueRequest;
|
||||
use App\Http\Requests\UpdateIssueRequest;
|
||||
use App\Models\Issue;
|
||||
use App\Models\IssueAttachment;
|
||||
use App\Models\IssueComment;
|
||||
@@ -108,31 +110,9 @@ class IssueController extends Controller
|
||||
return view('admin.issues.create', compact('users', 'labels', 'members', 'openIssues'));
|
||||
}
|
||||
|
||||
public function store(Request $request)
|
||||
public function store(StoreIssueRequest $request)
|
||||
{
|
||||
$validated = $request->validate([
|
||||
'title' => ['required', 'string', 'max:255'],
|
||||
'description' => ['nullable', 'string'],
|
||||
'issue_type' => ['required', Rule::in([
|
||||
Issue::TYPE_WORK_ITEM,
|
||||
Issue::TYPE_PROJECT_TASK,
|
||||
Issue::TYPE_MAINTENANCE,
|
||||
Issue::TYPE_MEMBER_REQUEST,
|
||||
])],
|
||||
'priority' => ['required', Rule::in([
|
||||
Issue::PRIORITY_LOW,
|
||||
Issue::PRIORITY_MEDIUM,
|
||||
Issue::PRIORITY_HIGH,
|
||||
Issue::PRIORITY_URGENT,
|
||||
])],
|
||||
'assigned_to_user_id' => ['nullable', 'exists:users,id'],
|
||||
'member_id' => ['nullable', 'exists:members,id'],
|
||||
'parent_issue_id' => ['nullable', 'exists:issues,id'],
|
||||
'due_date' => ['nullable', 'date'],
|
||||
'estimated_hours' => ['nullable', 'numeric', 'min:0'],
|
||||
'labels' => ['nullable', 'array'],
|
||||
'labels.*' => ['exists:issue_labels,id'],
|
||||
]);
|
||||
$validated = $request->validated();
|
||||
|
||||
$issue = DB::transaction(function () use ($validated, $request) {
|
||||
$issue = Issue::create([
|
||||
@@ -209,37 +189,10 @@ class IssueController extends Controller
|
||||
return view('admin.issues.edit', compact('issue', 'users', 'labels', 'members', 'openIssues'));
|
||||
}
|
||||
|
||||
public function update(Request $request, Issue $issue)
|
||||
public function update(UpdateIssueRequest $request, Issue $issue)
|
||||
{
|
||||
if ($issue->isClosed() && !Auth::user()->hasRole('admin')) {
|
||||
return redirect()->route('admin.issues.show', $issue)
|
||||
->with('error', __('Cannot edit closed issues.'));
|
||||
}
|
||||
|
||||
$validated = $request->validate([
|
||||
'title' => ['required', 'string', 'max:255'],
|
||||
'description' => ['nullable', 'string'],
|
||||
'issue_type' => ['required', Rule::in([
|
||||
Issue::TYPE_WORK_ITEM,
|
||||
Issue::TYPE_PROJECT_TASK,
|
||||
Issue::TYPE_MAINTENANCE,
|
||||
Issue::TYPE_MEMBER_REQUEST,
|
||||
])],
|
||||
'priority' => ['required', Rule::in([
|
||||
Issue::PRIORITY_LOW,
|
||||
Issue::PRIORITY_MEDIUM,
|
||||
Issue::PRIORITY_HIGH,
|
||||
Issue::PRIORITY_URGENT,
|
||||
])],
|
||||
'assigned_to_user_id' => ['nullable', 'exists:users,id'],
|
||||
'reviewer_id' => ['nullable', 'exists:users,id'],
|
||||
'member_id' => ['nullable', 'exists:members,id'],
|
||||
'parent_issue_id' => ['nullable', 'exists:issues,id'],
|
||||
'due_date' => ['nullable', 'date'],
|
||||
'estimated_hours' => ['nullable', 'numeric', 'min:0'],
|
||||
'labels' => ['nullable', 'array'],
|
||||
'labels.*' => ['exists:issue_labels,id'],
|
||||
]);
|
||||
// Authorization is handled by UpdateIssueRequest
|
||||
$validated = $request->validated();
|
||||
|
||||
$issue = DB::transaction(function () use ($issue, $validated) {
|
||||
$issue->update($validated);
|
||||
|
||||
Reference in New Issue
Block a user